Fix locale region override#7337
Merged
Merged
Conversation
robertbastian
requested review from
Manishearth,
nciric,
sffc and
zbraniecki
as code owners
sffc
approved these changes
Dec 22, 2025
| FixedCalendarDateTimeNames<icu_calendar::Gregorian>, | ||
| typed_date_time_names_size, | ||
| 328 | ||
| 336 |
Member
There was a problem hiding this comment.
Observation: Unfortunate that it increases stack size by 8 bytes
| let result = self | ||
| .region | ||
| .to_tinystr() | ||
| .to_ascii_lowercase() |
Member
Author
There was a problem hiding this comment.
yes, it wasn't lowercasing the region as required and your test failed
| .keywords | ||
| .get(&crate::extensions::unicode::key!("sd")) | ||
| .and_then(|v| v.as_single_subtag().copied()); | ||
| .and_then(|v| SubdivisionId::try_from_str(v.as_single_subtag()?.as_str()).ok()); |
Member
There was a problem hiding this comment.
Suggestion: Add comments about invalid subtags being silently ignored?
Suggestion/Follow-up: Check that the subdivision region matches the subtag region?
Member
Author
There was a problem hiding this comment.
it's existing behaviour, we need to do more work here anyway
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simpler version of #7335
#4413