This repository was archived by the owner on May 23, 2025. It is now read-only.
Feature/basic core cleanup #33
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utside the core app)
…cleanup Conflicts: gulp/scaffold/default.js
Collaborator
|
Same here, I like this a lot! |
backflip
reviewed
Jan 25, 2017
| * @param {object} options - The options passed as data attribute in the Module | ||
| */ | ||
| constructor($element, _defaultData, _defaultOptions, data, options) { | ||
| this.name = this.constructor.name.toLowerCase(); |
Collaborator
Member
There was a problem hiding this comment.
@backflip just tried it in current project (didn't have a look in depth) without success. I think that removing this needs more check, so we probably need to test it in a clean project first.
orioltf
pushed a commit
that referenced
this pull request
Mar 8, 2017
…NCOREL-178-c_23-concordia-med-tasks-frontend to develop * commit '789fc86650b90e621156a9c0e99ad254a702f26e': CONCOREL-178: Make sure the phone number wraps below title if the text is long CONCOREL-178: Make sure tel number doesnt brake. Use svg instead of png file CONCOREL-178: Refine docs for concorMed Reuse transitionDefault global var CONCOREL-178: Refine ConcordiaMed styling. Add docs CONCOREL-178: ConcordiaMed basic structure and data
Collaborator
|
@christiansany, can you have a look at this when working on unic/estatico-nou#3? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional to #32
Will move the registration of module classes out of the core EstaticoApp constructor. That core class should handle the app, but shouldn't be responsible for listing all modules.