Skip to content

Change ExamineIndexRebuilder to public access modifier #21038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Shazwazza wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

Change ExamineIndexRebuilder to public access modifier #21038

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Umbraco.Infrastructure/Examine/ExamineIndexRebuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

namespace Umbraco.Cms.Infrastructure.Examine;

internal class ExamineIndexRebuilder : IIndexRebuilder
public class ExamineIndexRebuilder : IIndexRebuilder
Copy link

Copilot AI Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making the class public is insufficient for proper extensibility. The private methods CanRun(), RebuildIndex(string, TimeSpan, CancellationToken), RebuildIndexes(bool, TimeSpan, CancellationToken), and ShouldRebuild(IIndex) should also be changed to protected virtual to allow derived classes to override the rebuild behavior. Without this, developers cannot override critical rebuild logic for scenarios like excluding certain server roles or handling persisted indexes in managed search services as mentioned in the PR description.

Copilot uses AI. Check for mistakes.
Copy link
Contributor Author

@Shazwazza Shazwazza Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is unnecessary, by implementing the IIndexRebuilder and explicitly implementing any methods on that interface will effectively override the members on the base class, no need to declare virtual.

{
private const string RebuildAllOperationTypeName = "RebuildAllExamineIndexes";

Expand Down
Loading