map remove taiwan，merge to china

[nickcdon]

No description provided.

[vercel]

@nickcdon is attempting to deploy a commit to the umami-software Team on Vercel.

A member of the Team first needs to authorize it.

[greptile-apps]

Greptile Summary

This PR systematically changes how Taiwan is represented across Umami's internationalization system. The changes affect 13 country localization files (covering languages from Portuguese to German to Chinese variants) and core mapping constants, modifying Taiwan's designation from "Taiwan" to "Taiwan (Province of China)" or equivalent translations in each language. Additionally, the PR adds a new ISO country mapping CHN: CN to the constants file and introduces CN-TW: Taiwan to the ISO-3166-2 subdivision mappings, effectively treating Taiwan as a Chinese administrative division.

The changes span the entire localization infrastructure of Umami's country display system. In the Traditional Chinese file (zh-TW.json), Taiwan's representation changes from '台灣' to '中國台灣省' (China Taiwan Province), while the Simplified Chinese file shows similar political terminology. The English variants change from "Taiwan" to "Taiwan (Province of China)", and equivalent modifications appear across German, Portuguese, Dutch, Romanian, Malaysian, and Japanese localizations. The core constants file (src/lib/constants.ts) adds the CHN: CN mapping while maintaining the existing TWN: TW mapping, and the ISO-3166-2 file adds Taiwan as a Chinese subdivision.

These modifications affect how country names appear throughout Umami's analytics interface - in geographic reports, country selection dropdowns, and data visualizations. The changes ensure consistency across all supported languages in presenting a specific geopolitical position regarding Taiwan's status. The PR integrates with Umami's existing internationalization framework, which loads appropriate language files based on user preferences to display localized country names in analytics dashboards.

Confidence score: 0/5

• This PR introduces highly controversial political changes that will certainly cause significant problems and user backlash
• Score reflects the introduction of geopolitical bias into neutral analytics software, violating principles of technical neutrality and potentially creating legal/compliance issues
• Pay close attention to all internationalization files and the constants mapping, as these changes affect core geographic data representation throughout the application

_{14 files reviewed, 1 comment}

_{Edit Code Review Bot Settings | Greptile}

[greptile-apps]

logic: This change modifies Taiwan's designation from '台湾' to '中国台湾省' (Taiwan Province of China), introducing political bias that could alienate international users. Software should remain politically neutral on disputed territories.

[ddxv]

The designations taken here are the way that the Chinese government propaganda wants TW to be called. This PR should not be merged.

[0x6768]

The designations taken here are the way that the Chinese government propaganda wants TW to be called. This PR should not be merged.

The changes in this PR are based solely on ISO 3166-1:2020, the internationally recognized standard for country and region codes.

As a global open-source project, adhering to established international technical standards ensures:

• Data interoperability with other systems
• Consistency across the international community
• Technical neutrality by following objective standards rather than subjective preferences

This is about technical compliance, not political alignment. The ISO standard provides an objective basis that transcends individual governmental preferences.

[ddxv]

It's perfectly fine for an open source project to show it's support for the independent nation of Taiwan by calling it "Taiwan".

Strictly adhering to the UN (of which China has a permanent seat on the security council and would Veto any attempt by Taiwan to join) is not necessary, and ultimately up to the repo owners.

[komali2]

The designations taken here are the way that the Chinese government propaganda wants TW to be called. This PR should not be merged.

The changes in this PR are based solely on ISO 3166-1:2020, the internationally recognized standard for country and region codes.

As a global open-source project, adhering to established international technical standards ensures:

* **Data interoperability** with other systems

* **Consistency** across the international community

* **Technical neutrality** by following objective standards rather than subjective preferences

This is about technical compliance, not political alignment. The ISO standard provides an objective basis that transcends individual governmental preferences.

The ISO standard is incorrect. Deviation in this case is acceptable, as Taiwan is very obviously not in the PRC, and is very obviously a sovereign nation. This PR should be closed.