Skip to content

feat: use nuqs to manange search params #3576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TinsFox wants to merge 3 commits into
base: master
Choose a base branch
from
+50 −6
Open

feat: use nuqs to manange search params #3576

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0b0c39a
feat: use nuqs to manange search params
TinsFox Aug 16, 2025
455c7ec
feat: use semantic naming
TinsFox Aug 16, 2025
8946f32
feat: replace useState with useQueryState for tab management in TeamD…
TinsFox Aug 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@
"next": "15.3.3",
"node-fetch": "^3.2.8",
"npm-run-all": "^4.1.5",
"nuqs": "^2.4.3",
"papaparse": "^5.5.3",
"prisma": "6.7.0",
"pure-rand": "^6.1.0",
Expand Down
33 changes: 33 additions & 0 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions pnpm-workspace.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,13 @@
packages:
- '**'

ignoredBuiltDependencies:
- cypress
- esbuild
- sharp

onlyBuiltDependencies:
- '@prisma/client'
- '@prisma/engines'
- prisma
- unrs-resolver
Copy link
Contributor

@greptile-apps greptile-apps bot Aug 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

syntax: The package name 'unrs-resolver' appears to be a typo. Based on the PR description mentioning 'nuqs', this should likely be 'nuqs' or verify the correct package name.

Suggested change
- unrs-resolver
- nuqs

5 changes: 3 additions & 2 deletions src/app/(main)/websites/[websiteId]/sessions/SessionsPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,13 @@ import SessionProperties from './SessionProperties';
import WorldMap from '@/components/metrics/WorldMap';
import { GridRow } from '@/components/layout/Grid';
import { Item, Tabs } from 'react-basics';
import { useState } from 'react';
import { useMessages } from '@/components/hooks';
import SessionsWeekly from './SessionsWeekly';
import { useQueryState } from 'nuqs';

export function SessionsPage({ websiteId }) {
const [tab, setTab] = useState('activity');
const [tab, setTab] = useQueryState('activity', { defaultValue: 'activity' });
Copy link
Contributor

@greptile-apps greptile-apps bot Aug 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: The query parameter key is set to 'activity' but this may be confusing since it represents the tab state, not just the activity tab. Consider using 'tab' as the key for clarity.


const { formatMessage, labels } = useMessages();

return (
Expand Down
6 changes: 4 additions & 2 deletions src/app/layout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import '@fontsource/inter/700.css';
import 'react-basics/dist/styles.css';
import '@/styles/index.css';
import '@/styles/variables.css';

import { NuqsAdapter } from 'nuqs/adapters/next/app';
export default function ({ children }) {
if (process.env.DISABLE_UI) {
return (
Expand All @@ -32,7 +32,9 @@ export default function ({ children }) {
<meta name="robots" content="noindex,nofollow" />
</head>
<body suppressHydrationWarning>
<Providers>{children}</Providers>
<Providers>
<NuqsAdapter>{children}</NuqsAdapter>
</Providers>
</body>
</html>
);
Expand Down