Repository navigation
Conversation
dancher00
marked this pull request as ready for review
November 2, 2026 19:22
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Fixes #182.
After nesting A → B, nesting B → A currently succeeds. Longer cycles are accepted too. The service now returns 422 when the proposed child already contains the parent at any depth.
The check walks membership links after write authorization and the duplicate-link check. It tracks visited collections so it terminates on legacy cycles, and permits shared descendants when they do not introduce a cycle. The nesting rules are documented.
How it was tested
37b9691; all seven now pass. Rejected links leave the existing chain intact.uv run --all-extras pytest— 887 passed, 11 end-to-end tests deselected by the default configuration.alembic check, downgrade to base and upgrade to head passed.Checklist
uv run ruff check .anduv run ruff format --check .passuv run pyrightpassesuv run --all-extras pytestpasses