Hide model logs in regression test output#4117
Draft
timothy-nunn wants to merge 1 commit intomainfrom
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4117 +/- ##
==========================================
+ Coverage 47.28% 47.51% +0.22%
==========================================
Files 139 141 +2
Lines 29330 29487 +157
==========================================
+ Hits 13868 14010 +142
- Misses 15462 15477 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
783731b to
24bca39
Compare
24bca39 to
f4448bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hides
process.model.*logs (except for critical) from being reported in the regression tests as a temporary measure to improve the PR review PROCESS. #2904 will provide a more robust solution to this problem which ensures we don't miss out on information.