Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4085 +/- ##
==========================================
+ Coverage 46.49% 46.56% +0.06%
==========================================
Files 124 124
Lines 28955 28974 +19
==========================================
+ Hits 13464 13491 +27
+ Misses 15491 15483 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ss methods and remove redundant static methods
…and PlasmaInductance class for improved clarity and maintainability
…s for improved organization and maintainability
…esson and Menard relations
chris-ashe
force-pushed
the
create_physics_inductance_class
branch
from
ad631d1 to
9a6bf37
Compare
timothy-nunn
requested changes
Feb 12, 2026
| MENARD = 2 | ||
|
|
||
|
|
||
| class PlasmaInductance: |
Collaborator
There was a problem hiding this comment.
Can we add a run() method to this model? Then we could move some of the calculations into it. I think we might be able to move these calculations into the run method:
ind_plasma_internal_norm_wessonind_plasma_internal_norm_menardind_plasma_internal_norm_iter_3
You probably could't move ind_plasma_internal_norm quite yet because it is used later on in physics.
process/physics.py
Outdated
Comment on lines
1523
to
1531
| # Calculate ind_plasma_internal_norm based on i_ind_plasma_internal_norm | ||
| try: | ||
| model = IndInternalNormModel( | ||
| int(physics_variables.i_ind_plasma_internal_norm) | ||
| ) | ||
| physics_variables.ind_plasma_internal_norm = ( | ||
| ind_plasma_internal_norm_calculations[ | ||
| int(physics_variables.i_ind_plasma_internal_norm) | ||
| ] | ||
| self.inductance.get_ind_internal_norm_value(model) | ||
| ) | ||
| else: | ||
| except ValueError: |
Collaborator
There was a problem hiding this comment.
Can you move all of this logic into a method of PlasmaIndustance so that here you just do
physics_variables.ind_plasma_internal_norm = self.inductance.calculate_ind_plasma_internal_norm(...)…ance class and streamline execution with run method
timothy-nunn
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
I confirm that I have completed the following checks: