Skip to content

CodeQL 14: refactor: convert foreach-add patterns to LINQ Select #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rlorenzo wants to merge 2 commits into
base: main
Choose a base branch
from
+21 −27
Open

CodeQL 14: refactor: convert foreach-add patterns to LINQ Select #200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3ecbe3
refactor: convert foreach-add patterns to LINQ Select
rlorenzo May 13, 2026
768fba1
chore(resharper): drop useless ToList() before LINQ-to-objects Select
rlorenzo May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 15 additions & 23 deletions web/Areas/CTS/Controllers/CourseController.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,18 +224,14 @@ public async Task<ActionResult<List<SessionCompetencyDto>>> AddSessionCompetency
return checkResult;
}

foreach (var levelId in sessionComp.LevelIds)
{
var newSessionComp = new SessionCompetency()
{
CompetencyId = sessionComp.CompetencyId,
SessionId = sessionComp.SessionId,
LevelId = levelId,
RoleId = sessionComp.RoleId,
Order = sessionComp.Order ?? 0
};
context.Add(newSessionComp);
}
context.AddRange(sessionComp.LevelIds.Select(levelId => new SessionCompetency()
{
CompetencyId = sessionComp.CompetencyId,
SessionId = sessionComp.SessionId,
LevelId = levelId,
RoleId = sessionComp.RoleId,
Order = sessionComp.Order ?? 0
}));
await context.SaveChangesAsync();

var sessionComps = await context.SessionCompetencies
Expand Down Expand Up @@ -270,18 +266,14 @@ public async Task<ActionResult<List<SessionCompetencyDto>>> UpdateSessionCompete
{
context.Remove(r);
}
foreach (var l in toAdd)
context.AddRange(toAdd.Select(l => new SessionCompetency()
{
var newSessionComp = new SessionCompetency()
{
CompetencyId = sessionComp.CompetencyId,
SessionId = sessionComp.SessionId,
LevelId = l,
RoleId = sessionComp.RoleId,
Order = sessionComp.Order ?? 0
};
context.Add(newSessionComp);
}
CompetencyId = sessionComp.CompetencyId,
SessionId = sessionComp.SessionId,
LevelId = l,
RoleId = sessionComp.RoleId,
Order = sessionComp.Order ?? 0
}));
await context.SaveChangesAsync();
await trans.CommitAsync();
}
Expand Down
10 changes: 6 additions & 4 deletions web/Areas/Directory/Models/IndividualSearchResult.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,11 +126,13 @@ public void LookupEmailHost(Classes.SQLContext.AAUDContext context)
// Sanitize MailId to prevent SQL injection in OPENQUERY (which doesn't support parameters)
var safeMailId = MailId.Replace("'", "''");
var query = $"SELECT * FROM OPENQUERY(UCDMothra,'SELECT (USERPART || ''@'' || HOSTPART) AS USERATHOST FROM MOTHRA.MAILIDS WHERE MAILID = ''{safeMailId}'' AND MAILSTATUS = ''A'' AND MAILTYPE = ''P''')";
var results = context.Database.SqlQueryRaw<string>(query).ToList();
foreach (var r in results)
var hosts = context.Database.SqlQueryRaw<string>(query)
.AsEnumerable()
.Select(r => r.Split("@")[^1])
.ToList();
if (hosts.Count > 0)
{
var parts = r.Split("@");
EmailHost = parts[^1];
EmailHost = hosts[^1];
}
}
}
Expand Down
Loading