PR 4: refactor: dead-code removal + shared chrome extraction

Viper.sln.DotSettings

@@ -0,0 +1,5 @@
+<wpf:ResourceDictionary xml:space="preserve" xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml" xmlns:s="clr-namespace:System;assembly=mscorlib" xmlns:ss="urn:shemas-jetbrains-com:settings-storage-xaml" xmlns:wpf="http://schemas.microsoft.com/winfx/2006/xaml/presentation">
+	<s:String x:Key="/Default/CodeStyle/CodeCleanup/Profiles/=OptimizeUsings/@EntryIndexedValue">&lt;Profile name="OptimizeUsings"&gt;&lt;CSOptimizeUsings&gt;&lt;OptimizeUsings&gt;True&lt;/OptimizeUsings&gt;&lt;EmbraceInRegion&gt;False&lt;/EmbraceInRegion&gt;&lt;RegionName&gt;&lt;/RegionName&gt;&lt;/CSOptimizeUsings&gt;&lt;/Profile&gt;</s:String>
+	<s:String x:Key="/Default/CodeStyle/CodeCleanup/Profiles/=ShortenReferences/@EntryIndexedValue">&lt;Profile name="ShortenReferences"&gt;&lt;CSShortenReferences&gt;True&lt;/CSShortenReferences&gt;&lt;/Profile&gt;</s:String>
+	<s:String x:Key="/Default/CodeStyle/CodeCleanup/Profiles/=RemoveRedundancies/@EntryIndexedValue">&lt;Profile name="RemoveRedundancies"&gt;&lt;CSRemoveCodeRedundancies&gt;True&lt;/CSRemoveCodeRedundancies&gt;&lt;RemoveCodeRedundancies&gt;True&lt;/RemoveCodeRedundancies&gt;&lt;CSRemoveRedundantArgumentDefaultValues&gt;True&lt;/CSRemoveRedundantArgumentDefaultValues&gt;&lt;CSRemoveRedundantInitializers&gt;True&lt;/CSRemoveRedundantInitializers&gt;&lt;/Profile&gt;</s:String>
+</wpf:ResourceDictionary>

VueApp/src/CAHFS/router/index.ts

@@ -1,15 +1,9 @@
-import { createRouter, createWebHistory } from "vue-router"
+import { createSpaRouter } from "@/shared/createSpaRouter"
 import { routes } from "./routes"
 import { useRequireLogin } from "@/composables/RequireLogin"
 import { checkHasOnePermission } from "@/composables/CheckPagePermission"
-import { useRouteFocus } from "@/composables/use-route-focus"
 
-const baseUrl = import.meta.env.VITE_VIPER_HOME
-const router = createRouter({
-    scrollBehavior: () => ({ left: 0, top: 0 }),
-    history: createWebHistory(baseUrl),
-    routes,
-})
+const router = createSpaRouter(routes)
 
 router.beforeEach(async (to) => {
     const { requireLogin } = useRequireLogin(to)
@@ -25,6 +19,4 @@ router.beforeEach(async (to) => {
     }
 })
 
-useRouteFocus(router)
-
 export { router as CAHFSRouter }

VueApp/src/CMS/router/index.ts

@@ -1,15 +1,9 @@
-import { createRouter, createWebHistory } from "vue-router"
+import { createSpaRouter } from "@/shared/createSpaRouter"
 import { routes } from "./routes"
 import { useRequireLogin } from "@/composables/RequireLogin"
 import { checkHasOnePermission } from "@/composables/CheckPagePermission"
-import { useRouteFocus } from "@/composables/use-route-focus"
 
-const baseUrl = import.meta.env.VITE_VIPER_HOME
-const router = createRouter({
-    scrollBehavior: () => ({ left: 0, top: 0 }),
-    history: createWebHistory(baseUrl),
-    routes,
-})
+const router = createSpaRouter(routes)
 
 router.beforeEach(async (to) => {
     const { requireLogin } = useRequireLogin(to)
@@ -25,6 +19,4 @@ router.beforeEach(async (to) => {
     }
 })
 
-useRouteFocus(router)
-
 export { router as cmsRouter }

VueApp/src/CTS/router/index.ts

@@ -1,15 +1,9 @@
-import { createRouter, createWebHistory } from "vue-router"
+import { createSpaRouter } from "@/shared/createSpaRouter"
 import { routes } from "./routes"
 import { useRequireLogin } from "@/composables/RequireLogin"
 import { checkHasOnePermission } from "@/composables/CheckPagePermission"
-import { useRouteFocus } from "@/composables/use-route-focus"
 
-const baseUrl = import.meta.env.VITE_VIPER_HOME
-const router = createRouter({
-    scrollBehavior: () => ({ left: 0, top: 0 }),
-    history: createWebHistory(baseUrl),
-    routes,
-})
+const router = createSpaRouter(routes)
 
 router.beforeEach(async (to) => {
     const { requireLogin } = useRequireLogin(to)
@@ -25,6 +19,4 @@ router.beforeEach(async (to) => {
     }
 })
 
-useRouteFocus(router)
-
 export { router }

VueApp/src/CTS/types/index.ts

@@ -272,22 +272,19 @@ export type {
     LegacyComptency,
     Epa,
     Assessment,
-    StudentEpaFormData,
     Level,
     ServiceSelect,
     Service,
     Student,
     Person,
     Role,
     Bundle,
-    BundleRole,
     BundleCompetency,
     CompetencyBundleAssociation,
     BundleCompetencyAddUpdate,
     BundleCompetencyGroup,
     Milestone,
     MilestoneLevel,
-    MilestoneLevelUpdate,
     Course,
     Session,
     Term,

VueApp/src/ClinicalScheduler/assets/schedule-shared.css

@@ -15,11 +15,11 @@
 }
 
 /* Shared typography for schedule pages */
-h3 {
+.clinical-scheduler-container h3 {
     color: var(--ucdavis-black-80);
-    font-size: 16px;
-    margin-top: 20px;
-    margin-bottom: 10px;
+    font-size: 1rem;
+    margin-top: 1.25rem;
+    margin-bottom: 0.625rem;
 }
 
 .schedule-note {
@@ -38,8 +38,8 @@ h3 {
 
 /* Mobile responsiveness for main headers */
 @media (max-width: 768px) {
-    h2 {
-        font-size: 18px;
+    .clinical-scheduler-container h2 {
+        font-size: 1.125rem;
     }
 
     /* Shared mobile badge positioning */
@@ -93,7 +93,7 @@ h3 {
 }
 
 @media (max-width: 480px) {
-    h2 {
-        font-size: 16px;
+    .clinical-scheduler-container h2 {
+        font-size: 1rem;
     }
 }

VueApp/src/ClinicalScheduler/components/WeekCell.vue

@@ -176,7 +176,7 @@ function isNewlyAdded(assignmentId: number): boolean {
     return newlyAddedAssignments.value.has(assignmentId)
 }
 
-export interface WeekAssignment {
+interface WeekAssignment {
     id: number
     displayName: string
     isPrimary?: boolean
@@ -355,8 +355,6 @@ const cardClasses = computed(() => {
 </script>
 
 <style scoped>
-@import url("@/styles/colors.css");
-
 .week-schedule-card {
     max-width: 280px;
     min-width: 200px;

VueApp/src/ClinicalScheduler/composables/use-schedule-normalization.ts

@@ -106,14 +106,4 @@ function useScheduleNormalization() {
     }
 }
 
-// Export all functions together
-export {
-    normalizeWeek,
-    normalizeSemesterWeeks,
-    normalizeScheduleSemesters,
-    filterExcludedRotations,
-    getAssignedRotationNames,
-    normalizeClinicianSchedule,
-    normalizeRotationSchedule,
-    useScheduleNormalization,
-}
+export { normalizeWeek, normalizeScheduleSemesters, useScheduleNormalization }

VueApp/src/ClinicalScheduler/constants/permission-messages.ts

@@ -28,10 +28,4 @@ const SCHEDULE_OPERATION_ERRORS = {
     NO_PERMISSION_MODIFY_PRIMARY_EVALUATOR: "You do not have permission to modify primary evaluator status.",
 } as const
 
-// All permission-related messages
-const PERMISSION_MESSAGES = {
-    ...ACCESS_DENIED_MESSAGES,
-    ...SCHEDULE_OPERATION_ERRORS,
-} as const
-
-export { ACCESS_DENIED_MESSAGES, ACCESS_DENIED_SUBTITLES, SCHEDULE_OPERATION_ERRORS, PERMISSION_MESSAGES }
+export { ACCESS_DENIED_MESSAGES, ACCESS_DENIED_SUBTITLES, SCHEDULE_OPERATION_ERRORS }

VueApp/src/ClinicalScheduler/constants/schedule-config.ts

@@ -61,38 +61,4 @@ const SCHEDULE_LABELS = {
     },
 } as const
 
-const SCHEDULE_VIEW_CONFIG = {
-    // Common view props
-    DEFAULT_PROPS: {
-        showLegend: true,
-        showPrimaryToggle: true,
-        labelSpacing: "xs" as const,
-        selectorSpacing: "none" as const,
-    },
-
-    // Rotation view specific
-    ROTATION_VIEW: {
-        showWarningInLegend: true,
-        showWarningIcon: true,
-        requiresPrimaryForWeek: true,
-        labelSpacing: "md" as const,
-        selectorSpacing: "lg" as const,
-    },
-
-    // Clinician view specific
-    CLINICIAN_VIEW: {
-        showWarningInLegend: false,
-        showWarningIcon: false,
-        requiresPrimaryForWeek: false,
-    },
-} as const
-
-// Type helpers for the constants
-type ScheduleMessageKey = keyof typeof SCHEDULE_MESSAGES
-type ScheduleLabelKey = keyof typeof SCHEDULE_LABELS
-type ViewConfigKey = keyof typeof SCHEDULE_VIEW_CONFIG
-
-// Consolidated exports - types and constants at end of file
-export { SCHEDULE_MESSAGES, SCHEDULE_LABELS, SCHEDULE_VIEW_CONFIG }
-
-export type { ScheduleMessageKey, ScheduleLabelKey, ViewConfigKey }
+export { SCHEDULE_MESSAGES, SCHEDULE_LABELS }