Symfony Migration for Tokens

[connersaeli]

Description

These changes redo many of the changes made in #2054 and the JupyterHub updates that were not merged into symfony_migration. Some relevant changes:

• Removed duplicate code from authenticateToken() in Tokens and BaseController that both extracted the raw token from the header.
• Removed a function that was commented out
• Removed HEADER_KEY and BEARER from Tokens (removed in Restore Data Analytics Framework token authentication via GET/POST params. #2054)
• Simplified logic checks for tokens. For example $request->headers->get() returns null if it is not present. There's no need here to check if it's null then get() only if it is present.
• Removed getTokenFromHeader() method because it is only used in one place now. This method is an artifact of having the different Silex/html controllers and needing this code in two different places. This method can just be replaced with a ternary operator.

Motivation and Context

https://github.com/ubccr/xdmod-xsede/issues/1171

Tests performed

Tested on my port of symfony-dev

Checklist:

• The pull request description is suitable for a Changelog entry
• The milestone is set correctly on the pull request
• The appropriate labels have been added to the pull request

[ryanrath]

Just the one question really.