Repository navigation
client: fix CPIO9P Readdir pagination, synthetic ancestor dirs, and Walk - #330
Merged
Merged
Conversation
CPIO9P previously assumed that CPIO archives always start with a "." directory record at index 0 and store all children of each directory contiguously after the parent record. In addition, Readdir unconditionally prepended "." even on continuation calls with a non-zero offset and used global record indices as Dirent.Offset cookies, causing 9P clients to loop infinitely or skip entries, while Walk failed on ".." at root and rec() had an off-by-one bounds check. Normalize record names in NewCPIO9PReaderAt, synthesize "." and any missing parent directory records, and index direct children per directory so Attach and Readdir work regardless of record ordering in the archive. Emit sequential 1-based Dirent.Offset continuation cookies in Readdir, clean Walk paths relative to "/" so "." and ".." resolve properly at any depth, and fix the rec() bounds check. Signed-off-by: Barret Rhoden <brho@google.com>
rminnich
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CPIO9P previously assumed that CPIO archives always start with a "." directory record at index 0 and store all children of each directory contiguously after the parent record. In addition, Readdir unconditionally prepended "." even on continuation calls with a non-zero offset and used global record indices as Dirent.Offset cookies, causing 9P clients to loop infinitely or skip entries, while Walk failed on ".." at root and rec() had an off-by-one bounds check.
Normalize record names in NewCPIO9PReaderAt, synthesize "." and any missing parent directory records, and index direct children per directory so Attach and Readdir work regardless of record ordering in the archive. Emit sequential 1-based Dirent.Offset continuation cookies in Readdir, clean Walk paths relative to "/" so "." and ".." resolve properly at any depth, and fix the rec() bounds check.