Repository navigation
Improve the error message for deserializing IndependentStyle - #48
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves typst/typst#8695
Continues #23
XmlDeErrorcontains the source error and the path at which the error occurred.citationberg/src/lib.rs
Lines 61 to 68 in 82f2b85
Previously,
XmlDeError::fmtshows only the path.However, sometimes the source error carries important info.
citationberg/src/lib.rs
Lines 308 to 310 in 82f2b85
For example, the above custom errors becomes the following
XmlDeError.This PR appends the source error after the path.