Introducing VortexSettings.. redux#30
Open
disc0infern0 wants to merge 3 commits intotwostraws:mainfrom
Open
Conversation
This change extracts the system wide parameters of a vortex system into its own struct, referenced from within the VortexSystem by the new variable `settings`. Doing the above removes the need for invoking .makeUniqueCopy() on the VortexSystem The seemingly large change is, after creating of VortexSettings, mostly changing references from VortexSystem to the new VortexSettings, except for the following:- - Shape, Color, ColorMode and SpawnOccasion are relocated to be within VortexSettings, as they relate to parameters in VortexSettings with those types. - The VortexView init now accepts a type of VortexSettings. - Presets and the Sandbox have been updated to use the VortexSettings initialiser, and for the presets, Xcode previews have been added. - secondarySystems is replaced by secondarySettings, and the spawn method in VortexSystem-Behaviour is updated as a result. - Readable and writable dynamic lookup has been to VortexSystem to minimize the impact on existing code. (References to secondarySystems will have to be updated) [ Aside: Odd shaped initialisers from previous PR's have been removed.]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introducing VortexSettings
This change extracts the system wide parameters of a vortex system into its own struct, referenced from within the VortexSystem by the new variable
settings.Doing the above removes the need for invoking .makeUniqueCopy() on the VortexSystem
The seemingly large change is, after creating of VortexSettings, mostly changing references from VortexSystem to the new VortexSettings, except for the following:-
[ Includes one tweak to the fireflies preview, to tidy up code relating to showing the instructions ]
[ Odd shaped initialisers from previous PR has been removed.]