Skip to content

fix: rework CRD splitting in apply_manifests - #66

Merged
Polychoronix merged 1 commit into
masterfrom
fix-apply-manifests
Apr 16, 2026
Merged

Polychoronix merged 1 commit into
masterfrom
fix-apply-manifests

Conversation

@Polychoronix

Copy link
Copy Markdown
Collaborator

When loading the entire manifest YAML with PyYAML, we may hit issues where values like - = aren't parsed correctly, leading to an error. This is a quick hacky fix that doesn't actually parse the YAML, but just checks the expected kind field for every document in the stream.

@Polychoronix
Polychoronix requested a review from twelho April 15, 2026 10:30
@Polychoronix Polychoronix self-assigned this Apr 15, 2026
@Polychoronix
Polychoronix force-pushed the add-nodeselector-flag branch 2 times, most recently from be44624 to cb7490b Compare April 15, 2026 10:32
@Polychoronix
Polychoronix changed the base branch from add-nodeselector-flag to master April 15, 2026 10:34
When loading the entire manifest YAML with PyYAML, we may hit issues
where values like `- =` aren't parsed correctly, leading to an error.
This is a quick hacky fix that doesn't actually parse the YAML, but just
checks the expected `kind` field for every document in the stream.

Signed-off-by: Veeti Poutsalo <veeti.poutsalo@craci.com>
@Polychoronix
Polychoronix enabled auto-merge April 16, 2026 08:53
@Polychoronix
Polychoronix merged commit ee269d6 into master Apr 16, 2026
4 checks passed
@Polychoronix
Polychoronix deleted the fix-apply-manifests branch April 16, 2026 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant