Skip to content

feat: support nested group to inherit the parent group/board dimension#1975

Closed
imrishabh18 wants to merge 1 commit intomainfrom
flex-core
Closed

feat: support nested group to inherit the parent group/board dimension#1975
imrishabh18 wants to merge 1 commit intomainfrom
flex-core

Conversation

@imrishabh18
Copy link
Member

No description provided.

@vercel
Copy link

vercel bot commented Feb 25, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
tscircuit-core-benchmarks Building Building Preview, Comment Feb 25, 2026 2:30pm

Request Review

Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's more complex than this, this won't work for deeply nested groups

@seveibar
Copy link
Contributor

@imrishabh18 it's not a matter of parsing props, it's about resolving the coordinates similar to the calc method with a resolution loop... anything else is just an implementation trap that will forever be buggy

@github-actions
Copy link

This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs.

@github-actions
Copy link

github-actions bot commented Mar 1, 2026

This PR was closed because it has been inactive for 1 day since being marked as stale.

@github-actions github-actions bot closed this Mar 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants