Skip to content

Properly indent -json CLI output for readability - #1174

Open
jahedullah wants to merge 1 commit into
tsantalis:masterfrom
jahedullah:fix/pretty-print-json-cli-output
Open

jahedullah wants to merge 1 commit into
tsantalis:masterfrom
jahedullah:fix/pretty-print-json-cli-output

Conversation

@jahedullah

@jahedullah jahedullah commented Sep 1, 2026 •

Copy link
Copy Markdown

Description:
Fixes the JSON format for -json CLI output by adding proper indentation, making it much more readable.

Testing:
Built a local Docker image and ran it against two commits; the output formatting was correct in both cases with proper indentation. The generated JSON file looks much better now.

@jahedullah jahedullah changed the title Properly indent -json CLI output for readabilit Properly indent -json CLI output for readability Sep 1, 2026
@jahedullah
jahedullah force-pushed the fix/pretty-print-json-cli-output branch from 26620f5 to b68f280 Compare September 1, 2026 19:46
@tsantalis

Copy link
Copy Markdown
Owner

@jahedullah
Thank you for your contribution in RefactoringMiner.
We have some tests the depend on the JSON output.
For example, /RefactoringMiner/src/test/java/org/refactoringminer/test/TestCommandLine.java
This test is not running in the CI, because it takes time, but I am running it locally. I am sure it would fail.

Moreover, our Chrome extension depends on the JSON, and I would need first to test that the new formatting does not break anything there.

In my opinion, the risks (i.e., breaking tests, breaking dependent projects) from this PR outweigh the benefits (i.e., JSON formatting).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants