Sanitize workspace name used as Cassandra keyspace (#1043)#1052
Closed
01AtharvR wants to merge 2 commits into
Closed
Sanitize workspace name used as Cassandra keyspace (#1043)#105201AtharvR wants to merge 2 commits into
01AtharvR wants to merge 2 commits into
Conversation
Contributor License Agreement ✅All contributors have signed the CLA. Thank you! |
Contributor
Author
|
Closing in favor of #1053 ,opened a fresh branch to rule out any stray local state after a disconnect during editing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
Fixes #1043 — Cassandra keyspace creation failed intermittently when a workspace name contained characters outside [a-zA-Z0-9_] (e.g. hyphens), since the raw workspace string was interpolated unquoted into CQL.
Changes
Added
sanitize_name()toEntityCentricKnowledgeGraph, matching the same pattern already used inrows/cassandraandrow_embeddings/qdrant.self.keyspaceis now sanitized at assignment time, so all CQL statements referencing it (create/drop/set keyspace) are safe.Note
cybermaggedon mentioned this affects Qdrant too,happy to look at that as a follow-up if this approach looks right.
Fixes #1043