fix: update knowledge manager tests for per-workspace librarian clients#1050
Merged
Conversation
Update test fixtures to use librarian_clients dict keyed by workspace instead of the removed librarian kwarg. Adjust mock references and add empty list-children response for recursive _stream_doc_tree.
Contributor License Agreement ✅All contributors have signed the CLA. Thank you! |
Contributor
Author
|
Confirmed tests pass in local dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
librarian_clients={"workspace": mock}dict instead of removedlibrarian=kwargmanager._mock_librarianinstead ofmanager.librarianlist-childrenresponse for recursive_stream_doc_treein download testFollows up on #1049 which changed
KnowledgeManagerfrom a single librarian to per-workspace clients.Test plan