RedHat build scripts: support for overriding release#527
Open
mbert wants to merge 1 commit intotrunkmaster:masterfrom
Open
RedHat build scripts: support for overriding release#527mbert wants to merge 1 commit intotrunkmaster:masterfrom
mbert wants to merge 1 commit intotrunkmaster:masterfrom
Conversation
* Use the same entry point for calling `rpmbuild'
* The rpm release can be overridden by `--release <release>' from the CL
* Simplified build error handling
* Automatically determine ${NEXTSPACE_DIR} in `build_all.sh'
* Make `build_all.sh' work again
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to provide better supports for frequent (nightly?) RPM builds from the master branch. The main obstacle is versioning: if a build comes out with the same version as the previous one, the RPMs are not cleanly upgradable. This is solved by making the
Releasefield in the RPM version overridable and setting it from the command line. Along with this I have removed some boilerplate code and simplified the build automation (I hope you agree).build_all.shcan be called as before, i.e. with no arguments.--release <release>which will cause<release>to override the respective values from the.specfiles when building the RPMs.build_all.shscript will now determine${NEXTSPACE_DIR}automatically, i.e. no longer needs it as a command line argument. Also, optionally, it can be called the same way as the other build scripts and will pass on the release override.Practical example:
The syntax for overriding stuff in the
.specfiles used byrpmspecandrpmbuildis awkward:--define "foo bar". I have opted not to useevalor bashisms which is why the two functionsrpm_version()andrun_rpmbuild()inPackaging/functions.shgot a bit lengthy.Optionally this here could be used for setting up nightly builds from which people could pull the RPMs and update their installations. As a nice-to-have this also could help identifying regressions in the RPM builds early.