ci: gke-preprod build target with custom banner (TRA-852)#421
Closed
mikestankavich wants to merge 1 commit into
Closed
ci: gke-preprod build target with custom banner (TRA-852)#421mikestankavich wants to merge 1 commit into
mikestankavich wants to merge 1 commit into
Conversation
Adds a parallel `gke-preprod` build target so the GKE cutover dry-run cluster can run a real backend image with an explicit "GKE pre-prod" banner instead of the generic "Preview" one — testers can tell at a glance they're on the GKE dry-run rather than the preview composition. Changes: - Push trigger now includes `gke-preprod` branch - metadata-action emits floating `:gke-preprod` tag for that ref - VITE_ENVIRONMENT resolution moved to a shell case (was nested GH Actions ternary). New cases: v-tag → empty, gke-preprod → "GKE pre-prod", default → "preview". Drive-by fix: the previous `startsWith(...) && '' || 'preview'` collapses to 'preview' always — `'' || 'preview'` short- circuits in GH expressions After merge: push `gke-preprod` from main so the image materializes. Infra (clear-wolf) pins helm to `:gke-preprod`. Delete the branch after Saturday's cutover; the trigger is harmless without a branch. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
🚀 Preview Deployment Update ✅ This PR has been successfully merged into the preview branch. The preview environment will update shortly at: https://app.preview.trakrf.id |
Contributor
Author
|
Superseded by TRA-853 (runtime-driven environment banner). Per Mike 2026-05-28: banner must be 100% runtime-driven from environment, not build-time baked — which makes a build-time gke-preprod target throwaway. Building the runtime fix instead; the GKE dry-run will set its banner via a pod env var on the same main image. Deleting the branch; no :gke-preprod image will be published. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a parallel
gke-preprodbuild target so the GKE cutover dry-run cluster (app.prod.gke.trakrf.id, TRA-850 / TRA-351) can run a real backend image with an explicit "GKE pre-prod" banner instead of the generic "Preview" one. Testers can then tell at a glance they're on the GKE dry-run rather than the regular preview composition.Changes
gke-preprodin addition tomainandpreview:gke-preprodtag, gated onrefs/heads/gke-preprodVITE_ENVIRONMENTresolution moved from a nested GH Actions ternary into a shell case. Three branches:refs/tags/v*→ empty (no banner),refs/heads/gke-preprod→"GKE pre-prod", default →"preview"${{ startsWith(github.ref, 'refs/tags/v') && '' || 'preview' }}collapsed to'preview'always, because'' || 'preview'short-circuits to'preview'in GH Actions expressions. Fixed in passing; harmless today since v-tags don't trigger this workflow yet, but the v-tag → empty intent is now actually honoredCoordination with trakrf-infra
imageTagfield inargocd/root/values.yaml) — drafted, holds untilghcr.io/trakrf/backend:gke-preprodis queryablegke-preprodfrom currentmain→ docker-build → image lands on GHCR. Will ping clear-wolf when both happengke-preprodbranch. The workflow trigger goes dormant, the existing image stays available for rollbackTest plan
ghcr.io/trakrf/backend:gke-preprodqueryable[GKE]:previewand:latestflow unaffected (existing image-updater track for preview keeps working)🤖 Generated with Claude Code