chore(backend): drop dead MQTT_TOPIC env / mqtt.topic value (TRA-922)#153
Merged
Merged
Conversation
Platform PR #475 (TRA-922) makes the ingest subscriber data-driven: it
subscribes to exactly the registered publish_topics ({org_slug}/.../reads)
via an in-memory registry and ignores MQTT_TOPIC entirely. The chart's
mqtt.topic (trakrf.id/+/reads, infra #147) is now dead config.
Remove the value and its MQTT_TOPIC env injection so the chart doesn't
read as a live subscription gate. No per-env (values-gke/aks/eks) or
argocd inlineValues override existed, so this is a clean removal.
Verified: helm template (mqtt.host set) renders the MQTT env block
without MQTT_TOPIC; helm lint clean.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes
mqtt.topic(trakrf.id/+/reads) fromhelm/trakrf-backend/values.yamland the correspondingMQTT_TOPICenv injection indeployment.yaml.Why
Hand-off from platform PR #475 (TRA-922, MQTT topic routing). That PR retires the backend's
MQTT_TOPICsubscription filter — the ingest subscriber is now data-driven, subscribing to exactly the registeredpublish_topics({org_slug}/.../reads) via an in-memory registry. The chart'smqtt.topic(added in infra #147) is dead config; the backend ignoresMQTT_TOPICafter #475.No per-env (
values-gke/aks/eks) or argocdinlineValuesoverride ofmqtt.topicexisted — the topic came solely from the chart default — so this is a clean removal.Verification
helm templatewithmqtt.hostset renders the MQTT env block (MQTT_USER→MQTT_PASSWORD→MQTT_URL→MQTT_CLIENT_ID) withoutMQTT_TOPIC.helm lintclean.Removing the env var changes the backend pod spec, so ArgoCD will roll the deployment (same pinned image, env removed). MQTT is live in preview (
mqttEnabled: true; prod isfalse). To avoid a window where the pre-#475 image restarts without a subscription topic, merge this only after #475's image is live in preview — unless platform confirms the pre-#475 backend tolerates an unsetMQTT_TOPIC, in which case order doesn't matter.Related: gate confirmed separately — cloud Mosquitto ACL is
topic readwrite #(not scoped totrakrf.id/), so slug-as-root topics are permitted at SUBSCRIBE. Future per-tenant scoping tracked in TRA-857.🤖 Generated with Claude Code