Handle error condition when sysDescr cannot be parsed.#38
Open
hardwaterhacker wants to merge 1 commit intotrailofbits:masterfrom
Open
Handle error condition when sysDescr cannot be parsed.#38hardwaterhacker wants to merge 1 commit intotrailofbits:masterfrom
hardwaterhacker wants to merge 1 commit intotrailofbits:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There seems to be an error case in
parse_snmp_pduthat's not being handled properly. During testing, I found some hosts where thelogrfunction wasn't printing out the sysDescr and wasn't inserting a newline. As a result, there were multiple results on one line, like the example below. A newline was finally inserted when a host with a parsable response was encountered.Result after testing with one affected host and multiple community strings. Note that these affected hosts respond with SNMP error number 2 (no such name). I do not believe that is relevant to this error condition, but I cannot confirm.
Packet capture when error condition is encountered.