Repository navigation
Fix AttributeError when checking EXT1, EXT2, and EXT4 pickles - #330
Merged
Merged
Conversation
EXT opcodes generate an ast.Import for `import copyreg, sys`, but both UnsafeImportsML and UnsafeImports accessed node.module as if every import were an ast.ImportFrom. This made check_safety() raise AttributeError instead of returning a verdict, even without registry mutation. Check every alias in ast.Import nodes and guard ImportFrom-specific checks in both analyzers. Preserve module-prefix matching and the safe-builtin exemption while retaining detection of the sys import.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EXTopcodes generate anast.Importforimport copyreg, sys, but bothUnsafeImportsMLandUnsafeImportsaccessednode.moduleas if every import were anast.ImportFrom. This madecheck_safety()raiseAttributeErrorinstead of returning a verdict, even without registry mutation.Check every alias in
ast.Importnodes and guardImportFrom-specific checks in both analyzers. Preserve module-prefix matching and the safe-builtin exemption while retaining detection of thesysimport.Fixes #329.