[ENCODEGEN,ARM64] Remove x86 instruction in ARM64 encoder template#34
Closed
TechnoPorg wants to merge 1 commit intotpde2:masterfrom
Closed
[ENCODEGEN,ARM64] Remove x86 instruction in ARM64 encoder template#34TechnoPorg wants to merge 1 commit intotpde2:masterfrom
TechnoPorg wants to merge 1 commit intotpde2:masterfrom
Conversation
Member
|
How did you hit this? AArch64 should have no relevant instructions with operand constraints to a single register. |
Contributor
Author
|
This showed up during one of my earlier attempts at 128-bit float to integer conversion, which generated the following code: Until your comment prompted me to remember why I had made this change, I had not realized that TPDE compiles without it now that I've moved away from encode_template.c for float to int conversion. |
8eacfb5 to
80d9928
Compare
Member
|
I removed the code in d3e9e59. Fixed register do not exist on AArch64 for the purposes of encodegen. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I came across this while working on rustc_codegen_tpde, whose TPDE patches I'll be working on upstreaming this week.