fix(webapp_internal): improve click interception handling and simplif… - #2068
Merged
Conversation
…y click strategy - Add ElementClickInterceptedException handling in base click method with debug logging - Initialize id_container and id_parent_element variables to prevent undefined reference errors - Implement enforce_on_top timeout mechanism to detect overlay interception during first half of timeout window - Add element_is_on_top() validation check to ensure elements are not intercepted by overlays - Simplify click strategy logic by removing progressive strategy index approach - Replace max_click_attempts constraint with flexible timeout-based retry loop - Remove unused initial_program variable declaration - Track current_clicked_element consistently across recapture attempts - Add explanatory comments for overlay detection and timeout behavior - Improve click verification loop to rely on timeout rather than fixed attempt count
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…y click strategy
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration: