Skip to content

fix: use toImageSrc for teddystudio label images to resolve host URL#306

Open
maxliesegang wants to merge 1 commit into
toniebox-reverse-engineering:developfrom
maxliesegang:develop
Open

fix: use toImageSrc for teddystudio label images to resolve host URL#306
maxliesegang wants to merge 1 commit into
toniebox-reverse-engineering:developfrom
maxliesegang:develop

Conversation

@maxliesegang

Copy link
Copy Markdown

No description provided.

@henryk86

henryk86 commented Jun 7, 2026

Copy link
Copy Markdown
Collaborator

Is this really necessary? On my side the current develop branch just works fine with locally hosted images and with public ones.

(I am ok with this change if it’s really necessary.)

@maxliesegang

Copy link
Copy Markdown
Author

My VITE_APP_TEDDYCLOUD_API_URL is set to http://tc.fritz.box in .env.development.local. Without toImageSrc, images fail to load. Using toImageSrc felt like the consistent approach since it's used everywhere else in the codebase. I think it has something to do with vite.config.ts using process.env to read the variable, which doesn't pick up .env file values there - but I'm not 100% sure and didn't want to touch it.

@henryk86

Copy link
Copy Markdown
Collaborator

Ok then fine for me. If it breaks something we can revert it easily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants