Skip to content

fix(custom-models): Issue #291 regressions and UX improvements#304

Closed
ditschi wants to merge 11 commits into
toniebox-reverse-engineering:developfrom
ditschi:bugfix/new-custom-model-manager-collection-of-improvements
Closed

fix(custom-models): Issue #291 regressions and UX improvements#304
ditschi wants to merge 11 commits into
toniebox-reverse-engineering:developfrom
ditschi:bugfix/new-custom-model-manager-collection-of-improvements

Conversation

@ditschi
Copy link
Copy Markdown

@ditschi ditschi commented May 17, 2026

Summary

Fixes issue #291: custom model manager regressions (unlock model assignment, list/pagination behaviour, loading state, mobile layout, dialog titles/i18n, Toniecard cleanup, legacy JSON handling, Prettier for CI).

Screenshots were taken with Playwright against a local dev instance (German UI), committed under docs/pr-screenshots/issue-291/ on this branch.


UI (Playwright captures)

Custom-Model-Editor — overview

Custom models list and actions

Filter and pagination

Filter panel and pagination

Edit custom model

Modell bearbeiten dialog

New custom model

Neues Modell dialog

Mobile layout

Custom models on mobile viewport

Tonies — Library (list context)

Library table

Tonies — Edit modal (Tonie/Tag, model assignment)

Edit Tonie modal


Test plan

  • Custom-Model-Editor: load list, filter, pagination, Zeige alle, edit/save/duplicate/delete.
  • Tonies overview: open edit modal; assign model where applicable.
  • Library: after save, list page behaviour matches expectation (New custom model manager - collection of improvements #291).
  • npm run format:check passes.

cursoragent and others added 11 commits May 17, 2026 21:27
Co-authored-by: Ditschi <ditschi@users.noreply.github.com>
Co-authored-by: Ditschi <ditschi@users.noreply.github.com>
Co-authored-by: Ditschi <ditschi@users.noreply.github.com>
Co-authored-by: Ditschi <ditschi@users.noreply.github.com>
Co-authored-by: Ditschi <ditschi@users.noreply.github.com>
Co-authored-by: Ditschi <ditschi@users.noreply.github.com>
Co-authored-by: Ditschi <ditschi@users.noreply.github.com>
Co-authored-by: Ditschi <ditschi@users.noreply.github.com>
Co-authored-by: Ditschi <ditschi@users.noreply.github.com>
Run npm run format so touched files match upstream Prettier rules and
format:check passes in CI.
…erse-engineering#291)

Add UI captures from local TeddyCloud for the pull request description.
@ditschi
Copy link
Copy Markdown
Author

ditschi commented May 17, 2026

Quick context: most of this work was AI-assisted (Cursor/agents). I then rebased onto develop, did manual checks in the dev sandbox, Playwright smoke tests for the #291 points, and a manual code pass. Happy for review where you want extra human scrutiny.

@henryk86
Copy link
Copy Markdown
Collaborator

henryk86 commented May 17, 2026

As said. The images in library view are still missing. Also in select a new source (select file file browser). It’s also shown in your screenshots:

All taf information except of the image is shown.

this should be revert to the same behaviour as it was before the first merge with the custom model editor.

and please remove the big folder icon image in case of a folder. That’s ugly and weird. Two times the folder icon. Thank you!

@henryk86
Copy link
Copy Markdown
Collaborator

henryk86 commented May 17, 2026


The margins of the in field icons still not correct. Actually it’s worsened. It changed the wrong icons. Dumb ai.

@henryk86
Copy link
Copy Markdown
Collaborator

henryk86 commented May 17, 2026

I assume any mobile thing in the editor is also not solved?

@ditschi ditschi closed this May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants