fix(custom-models): Issue #291 regressions and UX improvements#304
Closed
ditschi wants to merge 11 commits into
Closed
Conversation
Co-authored-by: Ditschi <ditschi@users.noreply.github.com>
Co-authored-by: Ditschi <ditschi@users.noreply.github.com>
Co-authored-by: Ditschi <ditschi@users.noreply.github.com>
Co-authored-by: Ditschi <ditschi@users.noreply.github.com>
Co-authored-by: Ditschi <ditschi@users.noreply.github.com>
Co-authored-by: Ditschi <ditschi@users.noreply.github.com>
Co-authored-by: Ditschi <ditschi@users.noreply.github.com>
Co-authored-by: Ditschi <ditschi@users.noreply.github.com>
Co-authored-by: Ditschi <ditschi@users.noreply.github.com>
Run npm run format so touched files match upstream Prettier rules and format:check passes in CI.
…erse-engineering#291) Add UI captures from local TeddyCloud for the pull request description.
Author
|
Quick context: most of this work was AI-assisted (Cursor/agents). I then rebased onto develop, did manual checks in the dev sandbox, Playwright smoke tests for the #291 points, and a manual code pass. Happy for review where you want extra human scrutiny. |
Collaborator
|
As said. The images in library view are still missing. Also in select a new source (select file file browser). It’s also shown in your screenshots: All taf information except of the image is shown. this should be revert to the same behaviour as it was before the first merge with the custom model editor. and please remove the big folder icon image in case of a folder. That’s ugly and weird. Two times the folder icon. Thank you! |
Collaborator
Collaborator
|
I assume any mobile thing in the editor is also not solved? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Fixes issue #291: custom model manager regressions (unlock model assignment, list/pagination behaviour, loading state, mobile layout, dialog titles/i18n, Toniecard cleanup, legacy JSON handling, Prettier for CI).
Screenshots were taken with Playwright against a local dev instance (German UI), committed under
docs/pr-screenshots/issue-291/on this branch.UI (Playwright captures)
Custom-Model-Editor — overview
Filter and pagination
Edit custom model
New custom model
Mobile layout
Tonies — Library (list context)
Tonies — Edit modal (Tonie/Tag, model assignment)
Test plan
Zeige alle, edit/save/duplicate/delete.npm run format:checkpasses.