fix: wallet v5 proof read #1605
Open
+73
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
+68
to
+72
| <Aside | ||
| type="note" | ||
| title="Wallet V5 and `wallet_id`" | ||
| > | ||
| Wallet V5 replaces `subwallet_id` with a derived 32‑bit `wallet_id` field that encodes network, wallet version, workchain, and subwallet number in a single value. The on-chain getter is still named `get_subwallet_id()` for backward compatibility, but for Wallet V5 it returns this derived `wallet_id`. See the [Wallet V5 overview](/standard/wallets/v5#wallet-id-scheme) for the exact scheme. |
There was a problem hiding this comment.
[HIGH] Stub “See …” sentence in Wallet V5 aside
The Wallet V5 aside ends with a standalone sentence, “See the Wallet V5 overview for the exact scheme.” This is a “stub” sentence whose sole purpose is to tell the reader to “See …” a link, which the style guide explicitly forbids in running prose. The guideline requires integrating the link naturally into the sentence instead of wrapping it in meta text like “See …”. Rephrasing the sentence keeps the content intact while aligning with the documented link-text and stub-sentence style rule.
Please leave a reaction 👍/👎 to this suggestion to improve future reviews for everyone!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1342