-
Notifications
You must be signed in to change notification settings - Fork 27
chore: tolk-vs-tlb #1578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore: tolk-vs-tlb #1578
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates here; I have one inline suggestion in docs.json: please apply the inline suggestion before merging.
| "group": "Migrating from FunC", | ||
| "pages": [ | ||
| "languages/tolk/from-func/tolk-vs-func", | ||
| "languages/tolk/from-func/tolk-vs-tlb", | ||
| "languages/tolk/from-func/stdlib-fc", | ||
| "languages/tolk/from-func/converter" | ||
| ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[HIGH] Deleted page leaves broken internal link
In docs.json the “Migrating from FunC” group no longer includes the languages/tolk/from-func/tolk-vs-tlb page in its pages array (L446–L451), while languages/tolk/from-func/tolk-vs-tlb.mdx has been deleted in this PR. However, languages/tolk/idioms-conventions.mdx still links to /languages/tolk/from-func/tolk-vs-tlb at https://github.com/ton-org/docs/blob/9f45aa2b4409ee09b41baca53fdb28d698b66a3a/languages/tolk/idioms-conventions.mdx?plain=1#L35-L41, so the link now targets a page that is no longer registered in the navigation or present in the tree. This turns a previously valid internal link into a broken target, violating the style guide’s global override against broken or missing anchors. Because the style guide treats broken internal links as always HIGH severity, this remains a HIGH issue.
Please leave a reaction 👍/👎 to this suggestion to improve future reviews for everyone!
|
Absolutely wrong. See a comment in #1577 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No documentation issues detected.
closes #1577