Introduce Scope type at the BrokerCli boundary.#1239
Open
floitsch wants to merge 1 commit into
Open
Conversation
The CLI is moving toward an org-agnostic data plane where each service (broker, pod-store, fleet-store) is told 'which slice of resources to operate on' via an opaque, per-service Scope instead of a hard-coded organization-id. This PR draws the line at the BrokerCli interface only: - Defines a new Scope type in src/cli/scope.toit. For now it just wraps a UUID; future PRs will let scopes carry richer (JSON-encodable) data for non-Supabase backends. - BrokerCli interface methods that took --organization-id/Uuid now take --scope/Scope. The HTTP impl unwraps to a UUID at the boundary; the Supabase impl inherits from HTTP and is unchanged. - The Broker wrapper class gains a scope getter (derived from its organization-id field for now) and uses it when calling BrokerCli internally. - Cache keys still take --organization-id directly; those are CLI-internal and will be migrated when scope becomes opaque. - Tests add a TEST-SCOPE constant in tests/utils.toit and use it at BrokerCli call sites. Wire protocol unchanged (broker payloads still use 'organization_id' / '_organization_id' JSON fields). No behavior change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CLI is moving toward an org-agnostic data plane where each service (broker, pod-store, fleet-store) is told 'which slice of resources to operate on' via an opaque, per-service Scope instead of a hard-coded organization-id.
This PR draws the line at the BrokerCli interface only:
Wire protocol unchanged (broker payloads still use 'organization_id' / '_organization_id' JSON fields). No behavior change.