Skip to content

*cake.qos: support unlimited bandwidth#177

Open
intelfx wants to merge 1 commit into
tohojo:mainfrom
intelfx:work/unlimited-bandwidth
Open

*cake.qos: support unlimited bandwidth#177
intelfx wants to merge 1 commit into
tohojo:mainfrom
intelfx:work/unlimited-bandwidth

Conversation

@intelfx

@intelfx intelfx commented Jan 27, 2025

Copy link
Copy Markdown

No description provided.

Signed-off-by: Ivan Shapovalov <intelfx@intelfx.name>
@intelfx intelfx force-pushed the work/unlimited-bandwidth branch from f0fc461 to 035a63d Compare January 27, 2025 03:19
@moeller0

Copy link
Copy Markdown
Collaborator

Quick note, did anyone test what this does with with fq_codel as selected qdisc?

@tohojo

tohojo commented Jan 27, 2025

Copy link
Copy Markdown
Owner

Erm, what's the point of supporting "unlimited" bandwidth? The whole point of sqm-scripts is to setup traffic shaping, without that you could just install a root qdisc, why do you need the complexity of sqm-scripts for this use case?

@intelfx

intelfx commented Jan 27, 2025

Copy link
Copy Markdown
Author

The whole point of sqm-scripts is to setup traffic shaping, without that you could just install a root qdisc, why do you need the complexity of sqm-scripts for this use case?

@tohojo Because this tool is a common abstraction that simplifies management of the tc subsystem for both cases. As I understand, at least CAKE is explicitly designed with support for running it without the shaping part:

IF you want to run at line rate for your device, relying instead on backpressure from the ethernet driver (and hopefully BQL) don’t specify the bandwidth.

@tohojo

tohojo commented Feb 10, 2025

Copy link
Copy Markdown
Owner

Sure, cake can run in unlimited mode just fine, but I'm not sure how much of a 'simplification' it is? I mean, there's literally a single sysctl you can set to select default qdisc for the system, which has the added benefit of also correctly installing an mq qdisc on multi-queue devices, with the selected qdisc as the sub-qdisc for each HW queue.

What's the full config you are using with 'unlimited' bandwidth? Are you setting any other cake parameters?

In any case, if we support this, we should also support this for non-cake qdiscs. Meaning that for fq_codel et al, we should skip the HTB/TBF setup and just install the qdisc on the root interface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants