Repository navigation
Verify Ed25519 OIDC identity tokens - #110
Open
asomervell wants to merge 1 commit into
Open
asomervell wants to merge 1 commit into
asomervell wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OIDC providers that sign ID tokens with Ed25519 currently fail browser sign-in because the verifier excludes EdDSA and ignores OKP keys. Add Ed25519 JWKS parsing and signature verification through the existing OIDC validation path.
The regression covers a verified token, a forged signature, an unverified email, and rejection of the X25519 curve. Existing issuer, audience, expiry, email policy, and key-algorithm matching remain enforced.
All 13 authentication unit tests passed locally and in a Linux release build using the repository-pinned Rust 1.97.1. The complete Linux server build and web build passed. The resulting server also passed a temporary loopback clone, push, and fetch check.