feat: add --version flag to root command #14
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why: Users expect --version flag as standard CLI pattern (issue #9) Approach: Set rootCmd.Version in createRootCmd, add functional tests Learned: Cobra auto-adds -v/--version when Version field is set Next: Create PR and close issue Changes: - Added rootCmd.Version = config.Version in createRootCmd() - Added functional tests for both 'version' subcommand and '--version' flag - Tests verify output format and exit code - All tests pass Fixes #9 🤖 Claude <[email protected]>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds standard --version flag support to otel-cli, complementing the existing version subcommand. The implementation leverages Cobra's built-in version functionality by setting the Version field on the root command.
Key changes:
- Enabled Cobra's built-in
--versionflag by settingrootCmd.Version - Added functional tests for both
versionsubcommand and--versionflag
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| otelcli/root.go | Sets rootCmd.Version to enable built-in --version flag support |
| data_for_test.go | Adds test cases validating both version subcommand and --version flag behavior |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for flag (and short form) to otel-cli, following standard CLI conventions.
Changes
Testing
Functional tests added:
Both test that:
Manual testing:
Related
Fixes #9
🤖 Generated with Claude Code
Co-Authored-By: Claude [email protected]