fix: Add missing expression on if template tag - #99
Merged
timonweb merged 1 commit intoApr 23, 2026
Merged
Conversation
Owner
|
@ironworld thank you! |
timonweb
added a commit
that referenced
this pull request
Apr 23, 2026
Restore missing comparison expression in pagination.html {% if %} tag (#99).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While reviewing the pagination template, I noticed I missed adding the == comparison operator in my previous fix. The
{% if %}expression was left as:{% if page page_obj.number %}instead of:
{% if page == page_obj.number %}Without the operator, Django raises a TemplateSyntaxError: Unused 'page_obj.number' at end of if expression, which means the pagination template was completely broken.
This PR fixes the expression and adds a test (
test_pagination_highlights_only_current_page) that renders the pagination template and asserts only the current page gets the is-current class — so this kind of mistake won't slip through CI again.