[Perf][Argreduce] Add adaptive streaming pair reduction - #1811
Draft
stelladuyx wants to merge 2 commits into
Draft
[Perf][Argreduce] Add adaptive streaming pair reduction#1811stelladuyx wants to merge 2 commits into
stelladuyx wants to merge 2 commits into
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #1804.
Summary
(value, index)pair reductionWhy
The implementation in #1804 removed one large fragment, but it still materialized a complete input row in shared memory and scanned the reduction dimension serially. It could not execute the manifest LM-head workload at
N=102400, and non-last-axis reductions materialized a transposed contiguous tensor.This version replaces that design rather than incrementally extending it.
Implementation
inner_stride, avoiding the transposeH200 performance
CUPTI kernel time with L2 flushing, physical GPU 1:
Compared with the production kernel before #1804, the shared workloads improve by about 10.3x, while the non-last-axis workload improves by about 82x. The four LM-head cases change from unsupported/skipped to passing.
Validation
pytest tests/ops/test_argreduce.py -q— 90 passedpytest benchmarks/ops/bench_argreduce.py -q— 9 passed, 0 skippedpytest benchmarks/tests/test_run_benchmarks.py tests/test_ops_manifest.py -q— 12 passedruff checkand pre-commit hooks — passedtorch.compileexact-output check — passed