Repository navigation
Conversation
tlambrou
requested review from
danielsitnik,
drudge and
matslina
as code owners
September 9, 2026 01:16
Next StepsHello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:
Manual Review RequiredHang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Meeting Calendar: today’s timed events and live-meeting status from one iCloud, Google Calendar, or Outlook ICS subscription per installation. Users configure the link and appearance in Tidbyt’s mobile app; no separate hosting, device API token, or paid subscription is required.
The app rotates remaining events, recognizes common meeting providers, pages simultaneous calls, and merges overlapping/back-to-back busy intervals. It uses normal rotation, requests full animation playback, returns no image for empty/disabled states, and bounds graphic lifetime with
max_age. The standalone Starlark parser supports the documented recurrence/timezone subset and reports unsupported input instead of silently presenting a partial schedule. Setup, privacy, revocation, and compatibility limits are documented in the app README.The submitted package contains a single Starlark file and only standard Pixlet runtime imports. Maintained calendar/display modules are bundled in the source project; validation checks the generated artifact and runs all four suites against that exact bundle. Normal, active, and simultaneous-call preview GIFs remain byte-for-byte identical after bundling.
Tracking issue: https://github.com/tlambrou/tidbyt-calendar/issues/1
Review requirement
The single-file package resolves the bot’s multiple-file objection. The refreshed Modules result requests review of
http.star, which the app needs to fetch ICS subscriptions directly. URL validation restricts requests to HTTPS subscription endpoints for iCloud, Google Calendar, and Outlook. The app does not log subscription URLs or calendar contents.Validation
pixlet check apps/meetingcalendarpasses with upstream-pinned v0.34.0, without raising the one-second render threshold.Physical original-device testing is pending access to a device credential configuration. Hosted full-animation playback, no-image behavior, and expiration also remain pending hosted access; local rendering/pushing cannot establish those contracts. Low-level network exceptions cannot be caught in Pixlet 0.34.0, so prior-image expiration is the fallback; HTTP response and parser failures have safe error screens.
Synthetic previews