You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I would like to discuss these three new functions. I wanted to use inversions and drop chords independently from the chord notation in the mini notation and came up with this solution.
And I realize that I need to change the name of the functions because of ambiguity
@thgrund, had a only quick look. what are the ambiguities?
n.b.: I didn't know there are no chord inversion functions -- great addition!
What else is there to do, except resolving conflicts?
Oh! I forgot, that this MR exists xD Thanks @sss-create for mentioning it. The ambiguity is, that there is already a Prelude.drop function and in TidalCycles the function inv already exists in Sound.Tidal.UI.
And then we need to add unit tests for this. I already did this locally (I append theses tests to that comment).
If you have the capacity to resolve the conflicts, and to rename the functions + adding the unit tests, then I would really appreciate it :-)
Unfortunately I do have limited capacities right now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would like to discuss these three new functions. I wanted to use inversions and drop chords independently from the chord notation in the mini notation and came up with this solution.
My motivation comes from my system where I create harmonies and melodies in a totally different approach then we usually do in TidalCycles: https://github.com/thgrund/mrreason-setup/blob/main/README.md
But I think these functions (open, drop and inv) could be useful in general.