Skip to content

[codex] keep empty-cell drops inside grid bounds#992

Open
nexiumbiz-debug wants to merge 1 commit into
tiberiuzuld:masterfrom
nexiumbiz-debug:codex/fix-empty-cell-default-size-912
Open

[codex] keep empty-cell drops inside grid bounds#992
nexiumbiz-debug wants to merge 1 commit into
tiberiuzuld:masterfrom
nexiumbiz-debug:codex/fix-empty-cell-default-size-912

Conversation

@nexiumbiz-debug

Copy link
Copy Markdown
Contributor

Summary

  • clamp empty-cell drop items against the high grid bounds so default-sized items can still be dropped near the right/bottom edge
  • keep negative/outside-before-grid positions rejected by the existing collision path
  • add coverage for a 12-column grid where a 6-column default item is dropped at the trailing edge

Fixes #912.

Tests

  • npm run test-lib -- --watch=false
  • npm run build-lib

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gridster not allowing to add item when defaultItemCols and defaultItemRows is more then 1.

1 participant