Skip to content

SCAL-290587 Add Liveboard download Embed Actions to TSE SDK#459

Open
g-nitin-t wants to merge 1 commit intomainfrom
SCAL-290587
Open

SCAL-290587 Add Liveboard download Embed Actions to TSE SDK#459
g-nitin-t wants to merge 1 commit intomainfrom
SCAL-290587

Conversation

@g-nitin-t
Copy link
Collaborator

@g-nitin-t g-nitin-t requested a review from a team as a code owner March 9, 2026 11:49
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the ThoughtSpot Embed SDK by introducing granular control over Liveboard download functionalities. It provides new actions that enable developers to specify which download formats (PDF, XLSX, CSV) can be disabled, offering more flexibility in embedding Liveboards.

Highlights

  • New Liveboard Download Actions: Added DownloadLiveboardAsPdf, DownloadLiveboardAsXlsx, and DownloadLiveboardAsCsv to the Action enum, allowing developers to disable specific Liveboard download options in the ThoughtSpot Embed SDK.
Changelog
  • src/types.ts
    • Added new Action enum members for Liveboard download formats (PDF, XLSX, CSV).
    • Updated the SDK and ThoughtSpot version information for the DownloadLiveboard action and the newly added actions.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds new Action enum values to support downloading Liveboards in PDF, XLSX, and CSV formats. The implementation is straightforward, but I've noticed a minor inconsistency in the string values for the new XLSX and CSV actions compared to existing actions in the same enum. I've suggested a change to align them for consistency and to prevent potential issues.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 9, 2026

Open in StackBlitz

npm i https://pkg.pr.new/@thoughtspot/visual-embed-sdk@459

commit: 83388bf

@g-nitin-t g-nitin-t force-pushed the SCAL-290587 branch 2 times, most recently from f8cdcbd to e25305d Compare March 12, 2026 15:11
@shivam-kumar-ts
Copy link
Contributor

LGTM

@sonar-prod-ts
Copy link

sonar-prod-ts bot commented Mar 19, 2026

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants