SCAL-290587 Add Liveboard download Embed Actions to TSE SDK#459
SCAL-290587 Add Liveboard download Embed Actions to TSE SDK#459
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the ThoughtSpot Embed SDK by introducing granular control over Liveboard download functionalities. It provides new actions that enable developers to specify which download formats (PDF, XLSX, CSV) can be disabled, offering more flexibility in embedding Liveboards. Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds new Action enum values to support downloading Liveboards in PDF, XLSX, and CSV formats. The implementation is straightforward, but I've noticed a minor inconsistency in the string values for the new XLSX and CSV actions compared to existing actions in the same enum. I've suggested a change to align them for consistency and to prevent potential issues.
commit: |
f8cdcbd to
e25305d
Compare
|
LGTM |
|
SonarQube Quality Gate
|








Jira: https://thoughtspot.atlassian.net/browse/SCAL-290587