Repository navigation
fix a transparent window issue on Windows OS - #19
Merged
Merged
Conversation
currently toolkit is supposed to support opaque windows only. issue: thorvg/thorvg#4577
Member
Author
|
depends on: thorvg/thorvg#4895 |
hermet
marked this pull request as draft
October 6, 2026 16:32
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The change matches the intended behavior, but the external ThorVG backend’s opaque-window presentation still needs platform validation.
Review effort: Balanced
Findings: None
What changed in this PR
Updates the WebGPU window target to match the toolkit’s opaque-only window support and address unwanted transparency on Windows.
Changes:
- Switches the target color space from
ABGR8888toXBGR8888.
| File | Description |
|---|---|
| src/tvgWindow.cpp | Uses an opaque color space when configuring the WebGPU canvas target. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currently toolkit is supposed to support opaque windows only.
issue: thorvg/thorvg#4577