Repository navigation
api: support engine options in run() - #17
Merged
Merged
Conversation
hermet
added
API
hermet
force-pushed
the
hermet/enhance
branch
from
September 30, 2026 02:57
a37e1ed to
0452dbc
Compare
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Non-WebGPU builds fail to compile, and the unchanged shared-library version exposes an ABI break.
Review effort: Balanced
Findings: 2
Open (2)
What changed in this PR
Adds configurable ThorVG engine options to toolkit application execution and canvas creation.
Changes:
- Adds
EngineOptiontorun(). - Passes options to all rendering backends and CPU fallback.
- Improves API documentation references.
| File | Description |
|---|---|
inc/thorvg_toolkit.h |
Extends and documents the public API. |
src/tvgToolkit.cpp |
Propagates engine options to windows. |
src/tvgWindow.h |
Updates backend constructor declarations. |
src/tvgWindow.cpp |
Passes options into canvas factories. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Add an EngineOption parameter defaulting to EngineOption::Default. Pass the option to canvas creation for each rendering engine and CPU fallback. Add Doxygen references for API symbols and the engine option default. * This may introduce the ABI break
hermet
force-pushed
the
hermet/enhance
branch
from
September 30, 2026 03:03
0452dbc to
fb20f39
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an EngineOption parameter defaulting to EngineOption::Default. Pass the option to canvas creation for each rendering engine and CPU fallback.
Add Doxygen references for API symbols and the engine option default.