Created a factory to properly inject MediumEditor.#58
Open
austinthedeveloper wants to merge 1 commit intothijsw:masterfrom
austinthedeveloper:MediumEditor-inject
Open
Created a factory to properly inject MediumEditor.#58austinthedeveloper wants to merge 1 commit intothijsw:masterfrom austinthedeveloper:MediumEditor-inject
austinthedeveloper wants to merge 1 commit intothijsw:masterfrom
austinthedeveloper:MediumEditor-inject
Conversation
Owner
|
Thanks for this PR, has anybody time to look into this, @simison ? |
Collaborator
|
Very low on time right now, but LGTM (tho I didn't test this). I also think Factory is the right way to inject external libraries. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In certain circumstances, jshint will throw an error in applications where a plugin has not been declared correctly in Angular. When it is injected as a factory and called when needed, jshint will stop throwing that error.
This solution is based from this Stack Overflow question about injecting jQuery and underscore:
http://stackoverflow.com/questions/17408977/inject-jquery-and-underscore-to-angular-js-component