Starting the Io_scheduler structure#10
Open
joseims wants to merge 2 commits into
Open
Conversation
thiagomanel
requested changes
May 29, 2019
thiagomanel
left a comment
thiagomanel
left a comment
Owner
There was a problem hiding this comment.
just a batch of small sugestions
| self.track_size=track_size | ||
| self.current_position = 0 | ||
|
|
||
| def distance(self,new_position): |
Owner
There was a problem hiding this comment.
replace new_position by position
| @@ -0,0 +1,7 @@ | |||
| class Disk: | |||
Owner
There was a problem hiding this comment.
add spaces in the proper places self.track_size=track_size self.track_size = track_size
| self.current_position = 0 | ||
|
|
||
| def distance(self,new_position): | ||
| return (self.current_position - new_position)%self.track_size |
|
|
||
| class Random_scheduler(Scheduler): | ||
| def schedule(queue): | ||
| return r.randint(0,len(queue)) |
Owner
There was a problem hiding this comment.
it is expected to change the queue (remove the item index by the r.randint(0,len(queue)) (if the queue is not empty)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scheduler and Disk as simple classes