Add support for Zephyr debug slot manager and use it by default #10500
+86
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for Zephyr debug slot manager API to move away from hardocded slot allocation. The support is added with ifdef to be able to switch back to the old hardcoded debug lost 'management' Signed-off-by: Peter Ujfalusi <[email protected]>
Zephyr has support for dynamic debug slot management to replace the currently used wild-west style debug slot "allocation" Signed-off-by: Peter Ujfalusi <[email protected]>
ujfalusi
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
jsarha
approved these changes
Jan 28, 2026
Contributor
jsarha
left a comment
jsarha
left a comment
There was a problem hiding this comment.
Looks Ok and works nicely debug_stream.
kv2019i
approved these changes
Jan 28, 2026
Collaborator
kv2019i
left a comment
kv2019i
left a comment
There was a problem hiding this comment.
Code good, some typos in commit making it a bit hard to follow.
| @@ -20,11 +20,25 @@ | |||
| /* CPU specific mutexes for each circular buffer */ | |||
Collaborator
There was a problem hiding this comment.
Some typoes in commit (hardocded, "debug lost management"), code looks good.
lyakh
reviewed
Jan 29, 2026
| static struct cpu_mutex cpu_mutex[CONFIG_MP_MAX_NUM_CPUS]; | ||
|
|
||
| #ifdef CONFIG_INTEL_ADSP_DEBUG_SLOT_MANAGER | ||
| static struct debug_stream_slot_hdr *slot; |
Collaborator
There was a problem hiding this comment.
please give it a longer name. Names like this make grepping / tagging quite difficult. Can be an incremental patch.
dbaluta
reviewed
Jan 29, 2026
|
|
||
| struct cpu_mutex { | ||
| struct k_mutex m; | ||
| } __aligned(CONFIG_DCACHE_LINE_SIZE); |
Collaborator
There was a problem hiding this comment.
Is there any documentation about how this debugging works? We use mainly the serial console for imx-es.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of 'blindly' writing to debug slots using hardwired numbers, use the debug slot manager API to work with the slots.
In theory this change would allow more debug slot users to be enabled and only limited by the amount on slots available for the platform.