Keep reference to named routes instead of moving the route to a different array. Fixes #362#363
Open
mlgpuntnl wants to merge 4 commits intothephpleague:7.xfrom
Open
Keep reference to named routes instead of moving the route to a different array. Fixes #362#363mlgpuntnl wants to merge 4 commits intothephpleague:7.xfrom
mlgpuntnl wants to merge 4 commits intothephpleague:7.xfrom
Conversation
philipobenito
requested changes
Apr 9, 2026
Member
philipobenito
left a comment
philipobenito
left a comment
There was a problem hiding this comment.
Couple of small nitpicks commented, and would be nice to have a regression test for this, but otherwise thanks for finding and fixing
Member
|
Perfect, thanks @mlgpuntnl I'll get it merged in this weekend, I still need a little more testing of the whole of 7.x before tagging though, your feedback is welcome if you're actively using it. |
philipobenito
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.