feat!: soroban-sdk v27 on main + release-plz publishing - #14
Open
willemneal wants to merge 8 commits into
Open
Conversation
Move the workspace from soroban-sdk 25.0.2 to 27.0.0-rc.1 (the highest published v27; no stable v27 yet). No source changes are required — the `contracttrait` / `contractimpl(contracttrait)` APIs and storage/deployer calls used by admin-sep are unchanged across 25 -> 27. Bump MSRV and the pinned toolchain 1.87.0 -> 1.91.0 (required by soroban-sdk 27). Verified: `cargo build --target wasm32v1-none --release` (all 3 members) and `cargo test` (host) both pass. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Mirror the release-plz setup from stellar-scaffold/cli so admin-sep is formally published to crates.io as an rlib (release + release-pr jobs on push to main). Requires a CARGO_REGISTRY_TOKEN repo secret. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
0.2.0 supersedes the historical 0.1.0 (soroban-sdk 23.4.0) GitHub release and is the first crates.io publish, carrying the soroban-sdk 27 + by-reference API. Avoids ambiguity with the stale v0.1.0 tag. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two coupled changes so admin-sep can be formally published to crates.io as an rlib at soroban-sdk v27 (which downstream consumers — e.g. stellar-registry/contracts — need):
mainby mergingfeat/use_references(where chore!: bump soroban-sdk to 27.0.0-rc.1 #13 landed).mainwas still on soroban-sdk 23.4.0; the v27 work lived only onfeat/use_references. Resultingmain:soroban-sdk = 27.0.0-rc.1, by-referenceset_adminAPI, MSRV 1.91,admin-sepversion = 0.2.0(rlib,publish = true)..github/workflows/release.yml), mirroring the setup instellar-scaffold/cli: areleasejob + arelease-prjob on push tomain.Version: 0.2.0
0.2.0is the first crates.io publish and supersedes the historical0.1.0GitHub release (which was soroban-sdk 23.4.0, never published to crates.io). Using 0.2.0 avoids any clash with the stalev0.1.0tag.Verified (soroban-sdk 27.0.0-rc.1)
cargo build --target wasm32v1-none --release— all 3 members compile.cargo test— 2 passed, 0 failed.Before this can publish
CARGO_REGISTRY_TOKENrepo secret (crates.io API token). The workflow already wires it into both jobs.admin-sep0.2.0to crates.io and tags it (admin-sep-v0.2.0).Note on the existing
v0.1.0tagThe current
v0.1.0GitHub tag/release points at the old 23.4.0main(262af93), not this v27 work. Consider deleting/replacing it to avoid confusion.🤖 Generated with Claude Code