Repository navigation
fix: decompress streaming responses incrementally - #2993
Open
CodePrometheus wants to merge 1 commit into
Open
CodePrometheus wants to merge 1 commit into
CodePrometheus wants to merge 1 commit into
Conversation
Signed-off-by: Zixin Zhou <zhouzixin@apache.org>
✅ Deploy Preview for theagentrouter canceled.
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Goal
Decode each byte of a compressed streaming response once, so the cost grows linearly with the response length.
Before
decodeStreamingContentappends every chunk to a buffer and decompresses the whole buffer again, so CPU and allocations grow with the square of the response length. A few hundred KB of brotli SSE costs seconds of ext_proc CPU per request.After
One decompressor per response is fed one chunk at a time through an
iter.Pullcoroutine. If the stream ends before the last chunk, the router processor releases the decoder when the ext_proc stream closes. Error handling is unchanged: running out of input mid-stream is fine, and a stream truncated at end of stream or corrupt data still fails the request.ProcessResponseBodybenchmark, one chunk per SSE event: