querier: improve chunkseries iterator #8577
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpetkovski
previously approved these changes
Nov 30, 2025
Accessing the current chunk via the slice is expensive and we should generally prefer to call methods on the memoized "cur" here. Signed-off-by: Michael Hoffmann <[email protected]>
MichaHoffmann
force-pushed
the
mhoffmann/chunkseries-iterator-improvements
branch
from
ea821b5 to
153eb91
Compare
GiedriusS
reviewed
Dec 1, 2025
Member
GiedriusS
left a comment
GiedriusS
left a comment
There was a problem hiding this comment.
How benchmark results look like?
yeya24
approved these changes
Dec 1, 2025
saswatamcode
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accessing the current chunk via the slice is expensive and we should generally prefer to call methods on the memoized "cur" here. Moved the AtT at the bottom - an exhausted iterator should generally still be at its last value there so this should be sound - this removes a lot of AtT function call overhead. Did same with the Err() call as thats generally only interesting if we are not the last chunk and was surprisingly hot in profiles.
Changes
Verification