Skip to content

Parameter alwaysRun=true for before-methods forces execution of those methods - #1633

Closed
krmahadevan wants to merge 1 commit into
testng-team:masterfrom
krmahadevan:krmahadevan-fix-1622
Closed

Parameter alwaysRun=true for before-methods forces execution of those methods#1633
krmahadevan wants to merge 1 commit into
testng-team:masterfrom
krmahadevan:krmahadevan-fix-1622

Conversation

@krmahadevan

Copy link
Copy Markdown
Member

Closes #1622

Fixes #1622 .

Did you remember to?

  • Add test case(s)
  • Update CHANGES.txt

We encourage pull requests that:

  • Add new features to TestNG (or)
  • Fix bugs in TestNG

If your pull request involves fixing SonarQube issues then we would suggest that you please discuss this with the
TestNG-dev before you spend time working on it.

@krmahadevan
krmahadevan requested a review from juherr December 1, 2017 01:17
@juherr

juherr commented Mar 28, 2018

Copy link
Copy Markdown
Member

@krmahadevan Did you plan to update this PR according to #1622 (comment) ?
You can revert #683 if needed (but keep the test case)

@krmahadevan

Copy link
Copy Markdown
Member Author

@juherr - I will come back to this hopefully during this weekend and see what I can do with respect to this issue.

@aTan-aka-Xellos

Copy link
Copy Markdown

@krmahadevan @juherr Hello! Any updates on this PR? Also having troubles because of #1622 issue :(

@krmahadevan

Copy link
Copy Markdown
Member Author

@aTan-aka-Xellos - Thanks for reminding me on this. Let me see if I can get around to this over the weekend.

@juherr

juherr commented Aug 30, 2026

Copy link
Copy Markdown
Member

Closing in favor of #3453.

The underlying #1622 regression is still present on master, but this PR ties the behavior to configFailurePolicy, which does not match the documented semantics or the pre-6.9.5 behavior. Its regression test also remains green without the production change.

#3453 addresses the root cause by separating alwaysRun group semantics from configuration-failure bypassing, with red → green → red regression coverage for both SKIP and CONTINUE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: configuration methods @BeforeX / @AfterX, alwaysRun, and configfailurepolicy

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: Parameter alwaysRun=true for before-methods forces execution of those methods

3 participants